Repository navigation
fix(checkin): read Analytics Engine failures by body shape - #709
Merged
Merged
Conversation
A rejected Analytics Engine request copied its whole body into the reason, so an API gateway error showed a raw JSON envelope and a proxy error showed HTML. The reason now takes the gateway's error messages, keeps a plain-text SQL message, and drops HTML. The length cut no longer splits a surrogate pair, and a test pins the GraphQL `errors: null` success shape.
Collaborator
Author
|
🤖 Harlan Agent Kit Agent assessment of head 1c55315. The Service Review was stopped for this head because the Service reported No blocker found (confidence 95/100). With main's code, the new 401 and 502 tests fail. A live gateway envelope, fetched with a dummy account and no token, parses to its message. Twelve fuzzed Logged follow-ups, none above 80:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Follow-up to the logged findings on #706. No GitHub issue.
❓ Type of change
📚 Description
A rejected Analytics Engine request copied its whole body into the check-in reason. An API gateway error, such as a 401, showed a raw JSON envelope, and a proxy error showed 300 characters of HTML.
The reason now depends on the body: the gateway's
errors[].messagefor a JSON envelope, the message itself for a plain-text SQL error, and only the status for an HTML page. The 300-character cut now counts code points, so it never splits a surrogate pair. A new test pins the GraphQL success shape witherrors: null, so a stricter check cannot fail every Worker read unnoticed.